[PATCH] D55067: [HIP] Fix offset of kernel argument for AMDGPU target

[Matt Arsenault via Phabricator via cfe-commits]

arsenm added inline comments.


================
Comment at: lib/CodeGen/CGCUDANV.cpp:205
+    auto *Aux = CGM.getContext().getAuxTargetInfo();
+    if (Aux && Aux->getTriple().getArch() == llvm::Triple::amdgcn) {
+      auto *ArgTy = Arg->getType()->getPointerElementType();
----------------
Checking the specific target seems wrong. Shouldn't you just need to check if 
the value is byval or not?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D55067/new/

https://reviews.llvm.org/D55067



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits