Author: steveire
Date: Thu Nov 29 11:50:10 2018
New Revision: 347905
URL: http://llvm.org/viewvc/llvm-project?rev=347905&view=rev
Log:
Revert "NFC: Fix case of CommentVisitor::Visit methods"
This reverts commit 0859c80137ac5fb3c86e7802cb8c5ef56f921cce.
Modified:
cfe/trunk/include/clang/AST/CommentVisitor.h
cfe/trunk/lib/AST/ASTDumper.cpp
Modified: cfe/trunk/include/clang/AST/CommentVisitor.h
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/include/clang/AST/CommentVisitor.h?rev=347905&r1=347904&r2=347905&view=diff
==============================================================================
--- cfe/trunk/include/clang/AST/CommentVisitor.h (original)
+++ cfe/trunk/include/clang/AST/CommentVisitor.h Thu Nov 29 11:50:10 2018
@@ -23,10 +23,10 @@ template<template <typename> class Ptr,
class CommentVisitorBase {
public:
#define PTR(CLASS) typename Ptr<CLASS>::type
-#define DISPATCH(NAME, CLASS)
\
- return static_cast<ImplClass
*>(this)->Visit##NAME(static_cast<PTR(CLASS)>(C))
+#define DISPATCH(NAME, CLASS) \
+ return static_cast<ImplClass*>(this)->visit ##
NAME(static_cast<PTR(CLASS)>(C))
- RetTy Visit(PTR(Comment) C) {
+ RetTy visit(PTR(Comment) C) {
if (!C)
return RetTy();
@@ -44,13 +44,13 @@ public:
// If the derived class does not implement a certain Visit* method, fall back
// on Visit* method for the superclass.
#define ABSTRACT_COMMENT(COMMENT) COMMENT
-#define COMMENT(CLASS, PARENT)
\
- RetTy Visit##CLASS(PTR(CLASS) C) { DISPATCH(PARENT, PARENT); }
+#define COMMENT(CLASS, PARENT) \
+ RetTy visit ## CLASS(PTR(CLASS) C) { DISPATCH(PARENT, PARENT); }
#include "clang/AST/CommentNodes.inc"
#undef ABSTRACT_COMMENT
#undef COMMENT
- RetTy VisitComment(PTR(Comment) C) { return RetTy(); }
+ RetTy visitComment(PTR(Comment) C) { return RetTy(); }
#undef PTR
#undef DISPATCH
Modified: cfe/trunk/lib/AST/ASTDumper.cpp
URL:
http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/AST/ASTDumper.cpp?rev=347905&r1=347904&r2=347905&view=diff
==============================================================================
--- cfe/trunk/lib/AST/ASTDumper.cpp (original)
+++ cfe/trunk/lib/AST/ASTDumper.cpp Thu Nov 29 11:50:10 2018
@@ -589,18 +589,18 @@ namespace {
void dumpComment(const Comment *C);
// Inline comments.
- void VisitTextComment(const TextComment *C);
- void VisitInlineCommandComment(const InlineCommandComment *C);
- void VisitHTMLStartTagComment(const HTMLStartTagComment *C);
- void VisitHTMLEndTagComment(const HTMLEndTagComment *C);
+ void visitTextComment(const TextComment *C);
+ void visitInlineCommandComment(const InlineCommandComment *C);
+ void visitHTMLStartTagComment(const HTMLStartTagComment *C);
+ void visitHTMLEndTagComment(const HTMLEndTagComment *C);
// Block comments.
- void VisitBlockCommandComment(const BlockCommandComment *C);
- void VisitParamCommandComment(const ParamCommandComment *C);
- void VisitTParamCommandComment(const TParamCommandComment *C);
- void VisitVerbatimBlockComment(const VerbatimBlockComment *C);
- void VisitVerbatimBlockLineComment(const VerbatimBlockLineComment *C);
- void VisitVerbatimLineComment(const VerbatimLineComment *C);
+ void visitBlockCommandComment(const BlockCommandComment *C);
+ void visitParamCommandComment(const ParamCommandComment *C);
+ void visitTParamCommandComment(const TParamCommandComment *C);
+ void visitVerbatimBlockComment(const VerbatimBlockComment *C);
+ void visitVerbatimBlockLineComment(const VerbatimBlockLineComment *C);
+ void visitVerbatimLineComment(const VerbatimLineComment *C);
};
}
@@ -2670,18 +2670,18 @@ void ASTDumper::dumpComment(const Commen
}
dumpPointer(C);
dumpSourceRange(C->getSourceRange());
- ConstCommentVisitor<ASTDumper>::Visit(C);
+ ConstCommentVisitor<ASTDumper>::visit(C);
for (Comment::child_iterator I = C->child_begin(), E = C->child_end();
I != E; ++I)
dumpComment(*I);
});
}
-void ASTDumper::VisitTextComment(const TextComment *C) {
+void ASTDumper::visitTextComment(const TextComment *C) {
OS << " Text=\"" << C->getText() << "\"";
}
-void ASTDumper::VisitInlineCommandComment(const InlineCommandComment *C) {
+void ASTDumper::visitInlineCommandComment(const InlineCommandComment *C) {
OS << " Name=\"" << getCommandName(C->getCommandID()) << "\"";
switch (C->getRenderKind()) {
case InlineCommandComment::RenderNormal:
@@ -2702,7 +2702,7 @@ void ASTDumper::VisitInlineCommandCommen
OS << " Arg[" << i << "]=\"" << C->getArgText(i) << "\"";
}
-void ASTDumper::VisitHTMLStartTagComment(const HTMLStartTagComment *C) {
+void ASTDumper::visitHTMLStartTagComment(const HTMLStartTagComment *C) {
OS << " Name=\"" << C->getTagName() << "\"";
if (C->getNumAttrs() != 0) {
OS << " Attrs: ";
@@ -2715,17 +2715,17 @@ void ASTDumper::VisitHTMLStartTagComment
OS << " SelfClosing";
}
-void ASTDumper::VisitHTMLEndTagComment(const HTMLEndTagComment *C) {
+void ASTDumper::visitHTMLEndTagComment(const HTMLEndTagComment *C) {
OS << " Name=\"" << C->getTagName() << "\"";
}
-void ASTDumper::VisitBlockCommandComment(const BlockCommandComment *C) {
+void ASTDumper::visitBlockCommandComment(const BlockCommandComment *C) {
OS << " Name=\"" << getCommandName(C->getCommandID()) << "\"";
for (unsigned i = 0, e = C->getNumArgs(); i != e; ++i)
OS << " Arg[" << i << "]=\"" << C->getArgText(i) << "\"";
}
-void ASTDumper::VisitParamCommandComment(const ParamCommandComment *C) {
+void ASTDumper::visitParamCommandComment(const ParamCommandComment *C) {
OS << " " << ParamCommandComment::getDirectionAsString(C->getDirection());
if (C->isDirectionExplicit())
@@ -2744,7 +2744,7 @@ void ASTDumper::VisitParamCommandComment
OS << " ParamIndex=" << C->getParamIndex();
}
-void ASTDumper::VisitTParamCommandComment(const TParamCommandComment *C) {
+void ASTDumper::visitTParamCommandComment(const TParamCommandComment *C) {
if (C->hasParamName()) {
if (C->isPositionValid())
OS << " Param=\"" << C->getParamName(FC) << "\"";
@@ -2763,17 +2763,17 @@ void ASTDumper::VisitTParamCommandCommen
}
}
-void ASTDumper::VisitVerbatimBlockComment(const VerbatimBlockComment *C) {
+void ASTDumper::visitVerbatimBlockComment(const VerbatimBlockComment *C) {
OS << " Name=\"" << getCommandName(C->getCommandID()) << "\""
" CloseName=\"" << C->getCloseName() << "\"";
}
-void ASTDumper::VisitVerbatimBlockLineComment(
+void ASTDumper::visitVerbatimBlockLineComment(
const VerbatimBlockLineComment *C) {
OS << " Text=\"" << C->getText() << "\"";
}
-void ASTDumper::VisitVerbatimLineComment(const VerbatimLineComment *C) {
+void ASTDumper::visitVerbatimLineComment(const VerbatimLineComment *C) {
OS << " Text=\"" << C->getText() << "\"";
}
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
