riccibruno added a comment.
added inline comments
================
Comment at: include/clang/AST/ExprCXX.h:168
public:
- CXXMemberCallExpr(ASTContext &C, Expr *fn, ArrayRef<Expr*> args,
- QualType t, ExprValueKind VK, SourceLocation RP)
- : CallExpr(C, CXXMemberCallExprClass, fn, args, t, VK, RP) {}
+ CXXMemberCallExpr(ASTContext &C, Expr *fn, ArrayRef<Expr *> args, QualType t,
+ ExprValueKind VK, SourceLocation RP,
----------------
aaron.ballman wrote:
> Since you're already touching the line, can you correct the names `fn`,
> `args`, and `t` to match our naming conventions?
I was going to submit an NFC cleaning up all of `CallExpr` +
the classes deriving from it in one go (capitalization style,
`clang-format`, and so on).
I would prefer to avoid mixing style fixes in existing code
and functional changes.
================
Comment at: lib/Sema/SemaExpr.cpp:5607
- Fn = rewrite.get();
- TheCall->setCallee(Fn);
- goto retry;
----------------
aaron.ballman wrote:
> Why did this go away?
Because it is now set by the constructor of `CallExpr` or
`CUDAKernelCallExpr`. The call to `setCallee` was needed
before because the call expression was constructed before
this piece of code, but now we can just pass `Fn` to the
constructor.
Repository:
rC Clang
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D54902/new/
https://reviews.llvm.org/D54902
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
