dexonsmith added 1 blocking reviewer(s): arphaman. dexonsmith added a comment.
In D54630#1308605 <https://reviews.llvm.org/D54630#1308605>, @arphaman wrote: > Sounds convincing. > @dexonsmith What do you think? Besides maintaining correct behaviour, I think the most important thing here is that the code organization is logical. Header search is complicated and we should be trying to make/keep it simple. I'm a little skeptical that splitting this logic between cc1 and the driver will simplify things, but I haven't looked in detail and I'll defer to your (collective) judgement. > @ilya-biryukov I'm going to do some internal testing to see if we uncover any > issues. I've added you as a blocking reviewer since I think we should work through any uncovered issues pre-commit. Repository: rC Clang CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54630/new/ https://reviews.llvm.org/D54630 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
