jkorous marked 8 inline comments as done. jkorous added a comment. Thank you very much for the review Sam!
I am going to write proper unit tests and then just wait for Alex and Ben to take a look. ================ Comment at: clangd/XRefs.cpp:785 + } + Results.emplace_back(std::move(NewSymbol)); + } ---------------- sammccall wrote: > nit: push_back (and below) Sure, no problem. I have to admit I thought these two are the same but I guess you pointed this out because there's a functional difference. I'd appreciate if you could advise where can I learn the details. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D54799/new/ https://reviews.llvm.org/D54799 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
