aaron.ballman added a comment.
I think we're almost there -- I had a few outstanding questions about the
config options in the tests and making sure we cover all the cases.
================
Comment at:
test/clang-tidy/cppcoreguidelines-narrowing-conversions-castingliterals-option.cpp:3
+// RUN: -config="{CheckOptions: [ \
+// RUN: {key:
"cppcoreguidelines-narrowing-conversions.WarnOnFloatingPointNarrowingConversion",
value: 0}, \
+// RUN: {key: "cppcoreguidelines-narrowing-conversions.PedanticMode", value:
1} \
----------------
No need for this setting?
================
Comment at:
test/clang-tidy/cppcoreguidelines-narrowing-conversions-long-is-32bits.cpp:2-5
+// RUN: -config="{CheckOptions: [ \
+// RUN: {key:
"cppcoreguidelines-narrowing-conversions.WarnOnFloatingPointNarrowingConversion",
value: 0}, \
+// RUN: {key: "cppcoreguidelines-narrowing-conversions.PedanticMode", value:
0} \
+// RUN: ]}" \
----------------
No need for any of these settings?
================
Comment at:
test/clang-tidy/cppcoreguidelines-narrowing-conversions-narrowingfloatingpoint-option.cpp:2-5
+// RUN: -config="{CheckOptions: [ \
+// RUN: {key:
"cppcoreguidelines-narrowing-conversions.WarnOnFloatingPointNarrowingConversion",
value: 1}, \
+// RUN: {key: "cppcoreguidelines-narrowing-conversions.PedanticMode", value:
0} \
+// RUN: ]}" \
----------------
You can drop these lines, I believe, because they match the default values.
================
Comment at:
test/clang-tidy/cppcoreguidelines-narrowing-conversions-unsigned-char.cpp:2-5
+// RUN: -config="{CheckOptions: [ \
+// RUN: {key:
"cppcoreguidelines-narrowing-conversions.WarnOnFloatingPointNarrowingConversion",
value: 0}, \
+// RUN: {key: "cppcoreguidelines-narrowing-conversions.PedanticMode", value:
0} \
+// RUN: ]}" \
----------------
No need for these settings?
Repository:
rCTE Clang Tools Extra
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D53488/new/
https://reviews.llvm.org/D53488
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
