aaron.ballman accepted this revision. aaron.ballman added a comment. This revision is now accepted and ready to land.
LGTM aside from a minor commenting request. ================ Comment at: include/clang/ASTMatchers/ASTMatchers.h:4121 +/// \brief Matches expressions with potential side effects. +/// ---------------- side effects. -> side effects other than producing a value, such as a calling a function, throwing an exception, or reading a volatile variable. Repository: rC Clang https://reviews.llvm.org/D54830 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
