sammccall accepted this revision.
sammccall added a comment.
This revision is now accepted and ready to land.
Awesome!
================
Comment at: clangd/URI.cpp:202
+ ("Not a valid absolute path: " + AbsolutePath).str().c_str());
+ for (auto I = URISchemeRegistry::begin(), E = URISchemeRegistry::end();
+ I != E; ++I) {
----------------
for (auto& Entry : URISchemeRegistry::entries())
================
Comment at: clangd/tool/ClangdMain.cpp:93
+
+static cl::opt<bool> EnablTestScheme(
+ "enable-test-scheme",
----------------
EnableTestScheme
should the flag include "uri"?
================
Comment at: test/clangd/did-change-configuration-params.test:6
---
-{"jsonrpc":"2.0","method":"workspace/didChangeConfiguration","params":{"settings":{"compilationDatabaseChanges":{"/clangd-test/foo.c":
{"workingDirectory":"/clangd-test", "compilationCommand": ["clang", "-c",
"foo.c"]}}}}}
+{"jsonrpc":"2.0","method":"workspace/didChangeConfiguration","params":{"settings":{"compilationDatabaseChanges":{"/clangd-test/foo.c":
{"workingDirectory":"/clangd-test", "compilationCommand": ["clang", "-c",
"/clangd-test/foo.c"]}}}}}
---
----------------
what's up with this change? :-)
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54800
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
