mgorny added inline comments.
================
Comment at: test/CMakeLists.txt:76
+# Add lit test dependencies.
+set(llvm_utils_deps
+ FileCheck count not
----------------
Nitpicking a bit but I think it would be better to uppercase it for consistency.
================
Comment at: test/CMakeLists.txt:80
+foreach(dep ${llvm_utils_deps})
+ if (TARGET ${dep})
+ list(APPEND CLANGD_TEST_DEPS ${dep})
----------------
…and remove the space after `if`.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54798
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
