[PATCH] D54693: [clangd] Store source file hash in IndexFile{In,Out}

[Jan Korous via Phabricator via cfe-commits]

jkorous added a comment.

Hi Kadir, I have one small nit otherwise LGTM.



================
Comment at: clangd/index/Serialization.cpp:368
+    Reader Hash(Chunks.lookup("hash"));
+    llvm::StringRef Digest = Hash.consume(20);
+    Result.Digest.emplace();
----------------
Nit: Maybe we could use `Result.Digest.size()` and avoid having `20` hardcoded 
here?


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D54693



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits