cfe-commits added a subscriber: aaron.ballman. cfe-commits added a comment.
I don’t really have much more to add here except to refer you to the style guide: https://llvm.org/docs/CodingStandards.html#use-auto-type-deduction-to-make-code-more-readable Specifically this line: “Use auto if and only if it makes the code more readable or easier to maintain.” Given that 2 out of 2 reviewers who have looked at this have said it did not make the code more readable or easier to maintain for them , and have further said that they feel the return type is not “obvious from the context”, i do not believe this usage fits within our style guidelines. I don’t think it’s worth beating on this anymore though, because this is a lot of back and forth over something that doesn’t actually merit this much discussion. So in the interest of conforming to the style guide above, please remove auto and then start a thread on llvm-dev if you disagree with the policy - F7542440: msg-532-122.txt <https://reviews.llvm.org/F7542440> Repository: rC Clang https://reviews.llvm.org/D54405 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
