takuto.ikuta marked 2 inline comments as done.
takuto.ikuta added a comment.
Thank you for review!
================
Comment at: clang/lib/Driver/ToolChains/Clang.cpp:5529
+ false)) {
+ Arg *dllexportInlines =
Args.getLastArg(options::OPT__SLASH_Zc_dllexportInlines_);
+ if (Args.hasArg(options::OPT__SLASH_fallback) && dllexportInlines) {
----------------
hans wrote:
> We know there must be a OPT__SLASH_Zc_dllexportInlines_ flag at this point
> (because it's checked in the if above), so I think think you need "&&
> dllexportInlines" below.
>
> In the previous version, you output the getAsString() of the arg to the
> diagnostic. Don't you want to do this still?
Ah, I don't need to call getAsString() anymore.
Repository:
rL LLVM
https://reviews.llvm.org/D54426
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
