sammccall added inline comments.
================
Comment at: clangd/ClangdUnit.cpp:175
+ CTFactories.createChecks(CTContext.getPointer(), CTChecks);
+ for (const auto &Check : CTChecks) {
+ Check->registerPPCallbacks(*Clang);
----------------
hokein wrote:
> Maybe add the check names to the `Trace`?
that would be nice, but there's no API to get that info :-(
================
Comment at: clangd/ClangdUnit.cpp:468
+ X##ModuleAnchorSource
+LINK_TIDY_MODULE(CERT);
+LINK_TIDY_MODULE(Abseil);
----------------
hokein wrote:
> I'm curious how much does clangd binary size get increased.
It's now 21M stripped vs 18M before this patch.
The different with debug info is *much* larger for some reason... sadly this
will hurt link times.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D54204
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
