hokein added inline comments.

================
Comment at: clangd/index/SymbolCollector.cpp:555
+  auto Loc = findNameLoc(&ND);
+  if (!shouldIndexFile(SM, SM.getFileID(Loc), Opts, &FilesToIndexCache))
+    return nullptr;
----------------
ioeric wrote:
> Should we use `getTokenLocation` like what we do below?
`getTokenLocation` doesn't return a `SourceLocation`, it returns a 
`SymbolLocation`.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D54300



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to