JonasToth added a comment.
I think this check is ok in the current form, but does it really need to be in
upstream clang-tidy? You said its for migration only, so it is not valuable for
you for a long time either?
================
Comment at: clang-tools-extra/clang-tidy/zircon/FblMoveCheck.h:20
+
+/// Replace instances of fbl::move with std::move, and adds the <utility>
header
+/// if a replacement occurs.
----------------
Please highlight code with quotes (single or backticks)
================
Comment at: clang-tools-extra/test/clang-tidy/zircon-fbl-move.cpp:5
+
+void move(int i) {}
+
----------------
please add test for aliases, function pointers and similar indirections.
https://reviews.llvm.org/D54168
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
