hans accepted this revision. hans added a comment. This revision is now accepted and ready to land.
Okay, looks good to me (with a small nit). ================ Comment at: docs/UsersManual.rst:2852 /Brepro Emit an object file which can be reproduced over time + /clang: <arg> Pass <arg> to the clang driver /C Don't discard comments when preprocessing ---------------- ultra nit: no space between the colon and <arg> ================ Comment at: test/Driver/cl-options.c:619 + +// RUN: %clang_cl -O2 -### -- %s 2>&1 | FileCheck -check-prefix=NOCLANG %s +// NOCLANG: "--dependent-lib=libcmt" ---------------- I'm not sure this test adds much value.. https://reviews.llvm.org/D53457 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits