Szelethus added a comment. I read through your patch multiple times, have read your mail on cfe-dev, and I still couldn't find eve minor nits, well done!
However, both in the mail, and in this discussion, there are a lot of invaluable information about the inner workings of the analyzer, that I fear will be lost once this revision is closed, even though I don't think the main logic will change in the near future. It would be neat to document it for the next generation somewhere. Another thing, since we're directly testing the functionality of `SymbolReaper`, maybe it'd be worth to also include unit tests. I'll probably revisit this revision as I read through your followup patches, but I can't seem to find errors in the main logic straight away. GG! Repository: rC Clang https://reviews.llvm.org/D18860 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
