dblaikie added a subscriber: dblaikie.

================
Comment at: test/SemaTemplate/temp_arg_template.cpp:80
@@ +79,3 @@
+#if __cplusplus >= 201103L
+  static constexpr int N = sizeof...(Templates);
+#endif
----------------
It would be good if we tested for some specific behavior here other than "don't 
crash" (doing anything other than crashing is a bit underspecified) - maybe we 
should be testing that N has the right value?

(don't have quite enough context on the fix itself to sign off on it though, 
unfortunately :/)


http://reviews.llvm.org/D15743



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to