Hi Sam,
On 2 Nov 2018, at 13:31, Sam McCall <sammcc...@google.com> wrote:
> The move of OSLog.h and FormatString.h to AST doesn't look obviously correct.
> Do these really belong in this layer? I think this patch needs review from
> someone who knows AST/ better than myself... was there a review?
Eli reviewed the change for OSLog.h in https://reviews.llvm.org/D53514
<https://reviews.llvm.org/D53514> so that it could be used for the main part of
the change. After that it was discovered OSLog depends on the other format
helpers so there was still a circular dependency; I decided adding the others
was a minor enough change to just go ahead.
The only alternative I see would be an entirely new library (“MiniAnalysis”?),
which seems quite excessive.
> (If the do belong here: the namespaces and comments don't seem to have been
> updated)
Good point, I’ll get onto fixing that.
Cheers.
Tim.
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
