xazax.hun accepted this revision.
xazax.hun added a comment.

One question otherwise looks good.



================
Comment at: lib/StaticAnalyzer/Core/PlistDiagnostics.cpp:884
+  // even if we lex a tok::comma and ParanthesesDepth == 1.
+  const IdentifierInfo *__VA_ARGS__II = PP.getIdentifierInfo("__VA_ARGS__");
+
----------------
Is it possible to undef `__VA_ARGS__`? If so, can this cause problems? Should 
we use `findDirectiveAtLoc` instead?


https://reviews.llvm.org/D52986



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to