sammccall marked an inline comment as done.
sammccall added a comment.

Thanks Alex. @hokein, let me know if any concerns.

In https://reviews.llvm.org/D53953#1283044, @alexfh wrote:

> > error: unable to handle compilation, expected exactly one compiler job in 
> > '' [clang-diagnostic-error]
> >  Suppressed 1 warnings (1 with check filters).
> >  Found compiler error(s).
>
> That's preferred to the current behavior, but from a user perspective a more 
> descriptive message would be better (like "can't find file /some/file" or 
> "can't open file /some/file"). I don't know whether it's better to do in 
> clang proper or in clang-tidy, but it can be handled separately from this 
> patch.


Agreed, this error message template is really weird by itself, and the empty 
string makes it worse.
Will dig into it, agree it doesn't seem directly related.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D53953



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to