Re: [PATCH] D15710: [clang-tidy] Add non-inline function definition and variable definition check in header files.

[Haojian Wu via cfe-commits]

hokein marked 4 inline comments as done.

================
Comment at: clang-tidy/misc/DefinitionsInHeadersCheck.cpp:22
@@ +21,3 @@
+
+AST_MATCHER(NamedDecl, useHeaderFileExtension) {
+  SourceManager& SM = Finder->getASTContext().getSourceManager();
----------------
alexfh wrote:
> nit: This name is not clear to me. Did you mean `isHeaderFileExtension` or 
> `usesHeaderFileExtension`?
`IsHeaderFileExtension` is more descriptive. Have renamed to it now.


http://reviews.llvm.org/D15710



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits