JonasToth added a comment.

Thank you very much for contributing to LLVM/clang-tidy! More patches are 
always welcome ;)

I found one issue we have overseen that should be fixed. Would you be so kind 
and do that before comitting?



================
Comment at: test/clang-tidy/readability-const-return-type.cpp:6
+
+#include <type_traits>
+
----------------
One nit: system headers are not allowed in clang-tidy tests. We do mock the 
required content. Sorry that I overlooked that.

You can take the implementation from here: 
https://en.cppreference.com/w/cpp/types/add_cv


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D53025



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to