void closed this revision.
void marked 2 inline comments as done.
void added inline comments.


================
Comment at: include/clang/AST/Expr.h:898
+class ConstantExpr : public FullExpr {
+  Stmt *Val;
+public:
----------------
rsmith wrote:
> I think it'd be cleaner and simpler to move this field into the base class, 
> merging it with the corresponding member of `ExprWithCleanups`.
Oh good. I was wanting to do that. Done. :-)


Repository:
  rC Clang

https://reviews.llvm.org/D53475



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to