mcgrathr accepted this revision.
mcgrathr added inline comments.
This revision is now accepted and ready to land.
================
Comment at: clang/lib/Driver/ToolChains/Fuchsia.cpp:125
!Args.hasArg(options::OPT_static);
+ CmdArgs.push_back("-push-state");
+ CmdArgs.push_back("-as-needed");
----------------
I'd use the `--` version of all these GNU-compatible options since that's the
GNU-compatible syntax.
(But `-static` is still single-dash.)
================
Comment at: clang/lib/Driver/ToolChains/Fuchsia.cpp:132
}
CmdArgs.push_back("-lm");
}
----------------
`-lm` belongs inside the `--as-needed` umbrella too.
Repository:
rC Clang
https://reviews.llvm.org/D53854
_______________________________________________
cfe-commits mailing list
[email protected]
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
