george.karpenkov accepted this revision. george.karpenkov added a comment. This revision is now accepted and ready to land.
I much prefer this version. We've had the same problem with diffing plist output. One thing we have learned is using a FileCheck was definitely a bad idea, as it leads to unreadable, unmaintainable, and very hard to update tests, so either diff or your custom tool is way better. As for the ultimate solution, I'm still not sure: I agree that maintaining those `-I` flags is annoying. One option is having an extra flag to produce "stable" output, which does not include absolute URLs/versions/etc. https://reviews.llvm.org/D53814 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
