Szelethus added a comment. What are the feelings on moving some functions to the header file? That's the one thing I'm unsure about regarding this patch. I could've moved them to `CompilerInvocation.cpp`, but I since I plan on making `ConfigTable` private, `CompilerInvocation` needs to be a friend of `AnalyzerOptions`. Not that it's the end of the world, and similar classes (e.g.: `LangOptions`) work similarly.
The reason why I didn't do it straight away is that - it's nice that `AnalyzerOptions` handles configs on it's own. - if someone would like add a new config option and also add constraints (like it has to be an existing file) to that, facing the longer compilation times will be a burden anyways (because the .def file has to be modified), so I thought the maintenance cost of `parseConfig` won't be THAT bad, but I'd concede to the fact that these aren't the greatest of concerns, though. https://reviews.llvm.org/D53692 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
