rjmccall added inline comments.
================ Comment at: clang/lib/CodeGen/CGObjC.cpp:2480 + SuppressResultRetain); } ---------------- This switch is just checking what you already computed as `SuppressResultRetain`. Please just assert in the second case that the qualifier is `OCL_Weak`. Also, please stay consistent with the surrounding capitalization of local variables. ================ Comment at: clang/lib/CodeGen/CGObjC.cpp:2527 + return TryEmitResult(CGF.EmitScalarExpr(e), + !shouldRetainObjCLifetime(type.getObjCLifetime())); + } ---------------- Can we test constant-evaluability directly instead of only applying this when the declaration isn't otherwise used? https://reviews.llvm.org/D53674 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
