Author: vsapsai Date: Wed Oct 24 15:39:38 2018 New Revision: 345212 URL: http://llvm.org/viewvc/llvm-project?rev=345212&view=rev Log: [VFS] Remove 'ignore-non-existent-contents' attribute for YAML-based VFS.
'ignore-non-existent-contents' stopped working after r342232 in a way that the actual attribute value isn't used and it works as if it is always `true`. Common use case for VFS iteration is iterating through files in umbrella directories for modules. Ability to detect if some VFS entries point to non-existing files is nice but non-critical. Instead of adding back support for `'ignore-non-existent-contents': false` I am removing the attribute, because such scenario isn't used widely enough and stricter checks don't provide enough value to justify the maintenance. rdar://problem/45176119 Reviewers: bruno Reviewed By: bruno Subscribers: hiraditya, dexonsmith, sammccall, cfe-commits Differential Revision: https://reviews.llvm.org/D53228 Modified: cfe/trunk/lib/Frontend/ModuleDependencyCollector.cpp cfe/trunk/test/Modules/crash-vfs-headermaps.m cfe/trunk/test/Modules/crash-vfs-include-pch.m cfe/trunk/test/Modules/crash-vfs-ivfsoverlay.m cfe/trunk/test/Modules/crash-vfs-relative-incdir.m cfe/trunk/test/Modules/crash-vfs-run-reproducer.m cfe/trunk/test/VFS/Inputs/MissingVFS/vfsoverlay.yaml cfe/trunk/test/VFS/Inputs/Nonmodular/nonmodular-headers.yaml cfe/trunk/test/VFS/Inputs/bar-headers.yaml cfe/trunk/test/VFS/Inputs/vfsoverlay2.yaml Modified: cfe/trunk/lib/Frontend/ModuleDependencyCollector.cpp URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Frontend/ModuleDependencyCollector.cpp?rev=345212&r1=345211&r2=345212&view=diff ============================================================================== --- cfe/trunk/lib/Frontend/ModuleDependencyCollector.cpp (original) +++ cfe/trunk/lib/Frontend/ModuleDependencyCollector.cpp Wed Oct 24 15:39:38 2018 @@ -156,10 +156,6 @@ void ModuleDependencyCollector::writeFil // allows crash reproducer scripts to work across machines. VFSWriter.setOverlayDir(VFSDir); - // Do not ignore non existent contents otherwise we might skip something - // that should have been collected here. - VFSWriter.setIgnoreNonExistentContents(false); - // Explicitly set case sensitivity for the YAML writer. For that, find out // the sensitivity at the path where the headers all collected to. VFSWriter.setCaseSensitivity(isCaseSensitivePath(VFSDir)); Modified: cfe/trunk/test/Modules/crash-vfs-headermaps.m URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Modules/crash-vfs-headermaps.m?rev=345212&r1=345211&r2=345212&view=diff ============================================================================== --- cfe/trunk/test/Modules/crash-vfs-headermaps.m (original) +++ cfe/trunk/test/Modules/crash-vfs-headermaps.m Wed Oct 24 15:39:38 2018 @@ -32,7 +32,6 @@ // CHECKYAML: 'case-sensitive': // CHECKYAML-NEXT: 'use-external-names': 'false', // CHECKYAML-NEXT: 'overlay-relative': 'true', -// CHECKYAML-NEXT: 'ignore-non-existent-contents': 'false' // CHECKYAML: 'type': 'directory' // CHECKYAML: 'name': "/[[PATH:.*]]/Foo.framework/Headers", // CHECKYAML-NEXT: 'contents': [ Modified: cfe/trunk/test/Modules/crash-vfs-include-pch.m URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Modules/crash-vfs-include-pch.m?rev=345212&r1=345211&r2=345212&view=diff ============================================================================== --- cfe/trunk/test/Modules/crash-vfs-include-pch.m (original) +++ cfe/trunk/test/Modules/crash-vfs-include-pch.m Wed Oct 24 15:39:38 2018 @@ -33,7 +33,6 @@ void g() { double x = DBL_MAX; } // CHECKYAML: 'case-sensitive': // CHECKYAML-NEXT: 'use-external-names': 'false', // CHECKYAML-NEXT: 'overlay-relative': 'true', -// CHECKYAML-NEXT: 'ignore-non-existent-contents': 'false' // CHECKYAML: 'type': 'directory' // CHECKYAML: 'name': "/[[PATH:.*]]/out", // CHECKYAML-NEXT: 'contents': [ Modified: cfe/trunk/test/Modules/crash-vfs-ivfsoverlay.m URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Modules/crash-vfs-ivfsoverlay.m?rev=345212&r1=345211&r2=345212&view=diff ============================================================================== --- cfe/trunk/test/Modules/crash-vfs-ivfsoverlay.m (original) +++ cfe/trunk/test/Modules/crash-vfs-ivfsoverlay.m Wed Oct 24 15:39:38 2018 @@ -36,7 +36,6 @@ // CHECKYAML: 'case-sensitive': // CHECKYAML-NEXT: 'use-external-names': 'false', // CHECKYAML-NEXT: 'overlay-relative': 'true', -// CHECKYAML-NEXT: 'ignore-non-existent-contents': 'false' // CHECKYAML: 'type': 'directory' // CHECKYAML: 'name': "/[[PATH:.*]]/example" // CHECKYAML: 'contents': [ Modified: cfe/trunk/test/Modules/crash-vfs-relative-incdir.m URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Modules/crash-vfs-relative-incdir.m?rev=345212&r1=345211&r2=345212&view=diff ============================================================================== --- cfe/trunk/test/Modules/crash-vfs-relative-incdir.m (original) +++ cfe/trunk/test/Modules/crash-vfs-relative-incdir.m Wed Oct 24 15:39:38 2018 @@ -36,7 +36,6 @@ // CHECKYAML: 'case-sensitive': // CHECKYAML-NEXT: 'use-external-names': 'false', // CHECKYAML-NEXT: 'overlay-relative': 'true', -// CHECKYAML-NEXT: 'ignore-non-existent-contents': 'false' // CHECKYAML: 'type': 'directory' // CHECKYAML: 'name': "/[[PATH:.*]]/Inputs/crash-recovery/usr/include", // CHECKYAML-NEXT: 'contents': [ Modified: cfe/trunk/test/Modules/crash-vfs-run-reproducer.m URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/Modules/crash-vfs-run-reproducer.m?rev=345212&r1=345211&r2=345212&view=diff ============================================================================== --- cfe/trunk/test/Modules/crash-vfs-run-reproducer.m (original) +++ cfe/trunk/test/Modules/crash-vfs-run-reproducer.m Wed Oct 24 15:39:38 2018 @@ -36,7 +36,6 @@ // CHECKYAML: 'case-sensitive': // CHECKYAML-NEXT: 'use-external-names': 'false', // CHECKYAML-NEXT: 'overlay-relative': 'true', -// CHECKYAML-NEXT: 'ignore-non-existent-contents': 'false' // CHECKYAML: 'type': 'directory' // CHECKYAML: 'name': "/[[PATH:.*]]/Inputs/crash-recovery/usr/include", // CHECKYAML-NEXT: 'contents': [ Modified: cfe/trunk/test/VFS/Inputs/MissingVFS/vfsoverlay.yaml URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/VFS/Inputs/MissingVFS/vfsoverlay.yaml?rev=345212&r1=345211&r2=345212&view=diff ============================================================================== --- cfe/trunk/test/VFS/Inputs/MissingVFS/vfsoverlay.yaml (original) +++ cfe/trunk/test/VFS/Inputs/MissingVFS/vfsoverlay.yaml Wed Oct 24 15:39:38 2018 @@ -1,6 +1,5 @@ { 'version': 0, - 'ignore-non-existent-contents': false, 'roots': [ { 'name': 'INPUT_DIR', 'type': 'directory', 'contents': [ Modified: cfe/trunk/test/VFS/Inputs/Nonmodular/nonmodular-headers.yaml URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/VFS/Inputs/Nonmodular/nonmodular-headers.yaml?rev=345212&r1=345211&r2=345212&view=diff ============================================================================== --- cfe/trunk/test/VFS/Inputs/Nonmodular/nonmodular-headers.yaml (original) +++ cfe/trunk/test/VFS/Inputs/Nonmodular/nonmodular-headers.yaml Wed Oct 24 15:39:38 2018 @@ -1,7 +1,6 @@ { 'version': 0, 'case-sensitive': 'false', - 'ignore-non-existent-contents': 'true', 'roots': [ { 'type': 'directory', Modified: cfe/trunk/test/VFS/Inputs/bar-headers.yaml URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/VFS/Inputs/bar-headers.yaml?rev=345212&r1=345211&r2=345212&view=diff ============================================================================== --- cfe/trunk/test/VFS/Inputs/bar-headers.yaml (original) +++ cfe/trunk/test/VFS/Inputs/bar-headers.yaml Wed Oct 24 15:39:38 2018 @@ -1,7 +1,6 @@ { 'version': 0, 'case-sensitive': 'false', - 'ignore-non-existent-contents': 'true', 'roots': [ { 'type': 'directory', Modified: cfe/trunk/test/VFS/Inputs/vfsoverlay2.yaml URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/VFS/Inputs/vfsoverlay2.yaml?rev=345212&r1=345211&r2=345212&view=diff ============================================================================== --- cfe/trunk/test/VFS/Inputs/vfsoverlay2.yaml (original) +++ cfe/trunk/test/VFS/Inputs/vfsoverlay2.yaml Wed Oct 24 15:39:38 2018 @@ -1,6 +1,5 @@ { 'version': 0, - 'ignore-non-existent-contents': false, 'roots': [ { 'name': 'OUT_DIR', 'type': 'directory', 'contents': [ _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
