sammccall added inline comments.
================ Comment at: clangd/Quality.cpp:380 + if (InBaseClass) + Score *= 0.7; + ---------------- ioeric wrote: > sammccall wrote: > > This seems like a pretty light penalty to me, I'd consider 0.5... > 0.5 sounds reasonable. I think we should penalize the non-instance member > case more if this is 0.5 though. Made that 0.2. WDYT? Agree, LG! Repository: rCTE Clang Tools Extra https://reviews.llvm.org/D53638 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
