sammccall added inline comments.
================
Comment at: clangd/ClangdLSPServer.cpp:112
+ SPAN_ATTACH(Tracer, "Params", Params);
+ ReplyOnce Reply(ID, Method, &Server, Tracer.Args);
log("<-- {0}({1})", Method, ID);
----------------
ioeric wrote:
> Do we have guarantee that `Tracer.Args` outlives `Reply`?
Yes, assuming the Handler propagates contexts properly.
The args are owned by the context created by the `trace::Span`.
Added a comment to `Span` to guarantee this.
Repository:
rCTE Clang Tools Extra
https://reviews.llvm.org/D53399
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
