This revision was automatically updated to reflect the committed changes.
Closed by commit rL345134: [clangd] Hide position line and column fields.
(authored by hokein, committed by ).
Herald added a subscriber: llvm-commits.
Repository:
rL LLVM
https://reviews.llvm.org/D53577
Files:
clang-tools-extra/trunk/clangd/index/Index.h
Index: clang-tools-extra/trunk/clangd/index/Index.h
===================================================================
--- clang-tools-extra/trunk/clangd/index/Index.h
+++ clang-tools-extra/trunk/clangd/index/Index.h
@@ -50,8 +50,7 @@
static constexpr uint32_t MaxLine = (1 << 20) - 1;
static constexpr uint32_t MaxColumn = (1 << 12) - 1;
- // Clients should use getters and setters to access these members.
- // FIXME: hide these members.
+ private:
uint32_t Line : 20; // 0-based
// Using UTF-16 code units.
uint32_t Column : 12; // 0-based
Index: clang-tools-extra/trunk/clangd/index/Index.h
===================================================================
--- clang-tools-extra/trunk/clangd/index/Index.h
+++ clang-tools-extra/trunk/clangd/index/Index.h
@@ -50,8 +50,7 @@
static constexpr uint32_t MaxLine = (1 << 20) - 1;
static constexpr uint32_t MaxColumn = (1 << 12) - 1;
- // Clients should use getters and setters to access these members.
- // FIXME: hide these members.
+ private:
uint32_t Line : 20; // 0-based
// Using UTF-16 code units.
uint32_t Column : 12; // 0-based
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
