sammccall accepted this revision. sammccall added inline comments. This revision is now accepted and ready to land.
================ Comment at: lib/Format/ContinuationIndenter.cpp:1594 StartColumn + NewPrefixSize - Style.ColumnLimit : 0; - return Fixes.second + PrefixExcessCharacters * Style.PenaltyExcessCharacter; + unsigned Penalty = + Fixes.second + PrefixExcessCharacters * Style.PenaltyExcessCharacter; ---------------- nit: why are you doing the multiline side-effect between computing the penalty and returning it? Repository: rC Clang https://reviews.llvm.org/D52448 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits