sammccall added a comment.

Logic looks good. Any way we can exercise it with a test via c-index-test?



================
Comment at: include/clang/Sema/CodeCompleteConsumer.h:281
+
+    /// Code completion occurred where an existing symbol is expected.
+    CCC_Symbol,
----------------
nit: try to describe what a symbol is in the comment, rather than just 
repeating the term?
e.g. "where an existing name is expected (such as a type, function, or 
variable)"


Repository:
  rC Clang

https://reviews.llvm.org/D53191



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to