AlexeySachkov marked 2 inline comments as done. AlexeySachkov added inline comments.
================ Comment at: lib/Headers/opencl-c.h:16197 +#ifdef cl_intel_device_side_avc_motion_estimation +#pragma OPENCL EXTENSION cl_intel_device_side_avc_motion_estimation : enable + ---------------- Anastasia wrote: > Anastasia wrote: > > Should we be using: > > #pragma OPENCL EXTENSION my_ext : begin > > then the user can get correct diagnostics that the functions can only be > > used once the extension is enabled. > Would it be better to use `begin`/`end` instead of `enable`/`disable`? Done, but https://reviews.llvm.org/D53200 have to be landed first to avoid failures in LIT tests https://reviews.llvm.org/D51484 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits