kadircet added inline comments.

================
Comment at: clangd/CodeComplete.cpp:700
+     unsigned DiagLoc = Loc.second;
+     if (DiagLoc < StartOfLine || DiagLoc > Offset)
+       return;
----------------
There are also a lot of cases where we can't find an include file(usually due 
to confused compile commands) and fail miserably. Maybe in addition to checking 
current line, we could also check for lines that are starting with `#include` 
or diags of type `diag::err_pp_file_not_found` ?


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D53406



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to