rnk added inline comments.
================ Comment at: cfe/trunk/include/clang/Serialization/GlobalModuleIndex.h:147 static std::pair<GlobalModuleIndex *, ErrorCode> - readIndex(StringRef Path); + readIndex(llvm::StringRef Path); ---------------- It's preferred to include clang/Basic/LLVM.h instead and use the StringRef in the clang namespace: https://github.com/llvm-mirror/clang/blob/master/include/clang/Basic/LLVM.h Otherwise we'd have llvm::StringRef literally everywhere. Repository: rL LLVM https://reviews.llvm.org/D53135 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
