arphaman added inline comments.

================
Comment at: lib/Lex/FilterToIncludes.cpp:628
+  First = Id.Last;
+  auto Kind = llvm::StringSwitch<TokenKind>(Id.Name)
+                  .Case("include", pp_include)
----------------
ddunbar wrote:
> What is our feeling w.r.t. _Pragma, which can in theory influence the 
> preprocessor. I'm not sure this model can sanely support it?
We need to look into that. In the worst case we can always avoid minimizing the 
file if it has a _Pragma anywhere in it.


Repository:
  rC Clang

https://reviews.llvm.org/D53354



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to