vsapsai marked 5 inline comments as done.
vsapsai added inline comments.
================
Comment at: clang/lib/Basic/VirtualFileSystem.cpp:934
RedirectingFileSystem &FS;
RedirectingDirectoryEntry::iterator Current, End;
+ bool IsExternalFSCurrent;
----------------
bruno wrote:
> Can you add comments to these new members? Specifically, what's the purpose
> of `IsExternalFSCurrent` and how it connects to `ExternalFS`
Added comments.
================
Comment at: clang/lib/Basic/VirtualFileSystem.cpp:940
- std::error_code incrementImpl();
+ std::error_code incrementExternal();
+ std::error_code incrementContent(bool IsFirstTime);
----------------
bruno wrote:
> Same for these methods
Added comments. Not entirely happy with them, would like to hear opinion of
others.
================
Comment at: clang/lib/Basic/VirtualFileSystem.cpp:1738
+ErrorOr<Status> RedirectingFileSystem::status(const Twine &Path,
+ bool ShouldCheckExternalFS) {
ErrorOr<Entry *> Result = lookupPath(Path);
----------------
bruno wrote:
> Is passing `ShouldCheckExternalFS ` really necessary? Why checking the status
> of the member isn't enough?
Not required anymore, simplified the code.
https://reviews.llvm.org/D50539
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
