leonardchan added inline comments.
================
Comment at: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp:90-92
+static llvm::cl::opt<std::string>
+ ClangDocExecutorName("doc-executor", llvm::cl::desc("The name of the
executor to use in clang-doc."),
+ llvm::cl::init("all-TUs"));
----------------
I think this might be more than 80 characters in a line? Run clang-format just
to be sure.
================
Comment at: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp:202-203
+llvm::Expected<std::unique_ptr<ToolExecutor>>
+createClangDocExecutor(int &argc, const char **argv,
+ llvm::cl::OptionCategory &Category) {
+ auto OptionsParser =
----------------
Formatting nit: Should the arguments be aligned here?
================
Comment at: clang-tools-extra/clang-doc/tool/ClangDocMain.cpp:211-213
+ if (I->getName() != ClangDocExecutorName) {
+ continue;
+ }
----------------
Nit: Remove braces
https://reviews.llvm.org/D53170
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
