Anastasia added inline comments. ================ Comment at: lib/CodeGen/CGOpenCLRuntime.cpp:108 @@ +107,3 @@ + PipeTy = llvm::PointerType::get(llvm::StructType::create( + CGM.getLLVMContext(), "opencl.pipe_t"), PipeAddrSpc); + } ---------------- pxli168 wrote: > Anastasia wrote: > > Yes, I think we might, otherwise I don't see how we are going to allows any > > element type (including user defined types) for pipe without adding a > > template like functionality to C parsing. > OK, I will send a patch only for these two builtin function (I don't think > other pipe functions need to be built-in), and I think we can discuss about > the function mangle for them, now I have a version without mangle and a hard > code version. I am afraid we might need to add all of the pipe functions as builtins in order to allow them to be called with any pipe element type including user defined types.
Otherwise, feel free to propose other ideas. If you have a patch already, let's start the review and we will see how to move forward. http://reviews.llvm.org/D15603 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
