mstorsjo added inline comments.
================
Comment at: lib/Driver/ToolChains/MinGW.cpp:266
+ // directives in the object files, but the static library needs
+ // -lpsapi unless the sanitizer was built targeting >= win7.
+ CmdArgs.push_back("-lpsapi");
----------------
smeenai wrote:
> Isn't Windows 7 our minimum supported Windows version anyway? I can't find
> the documentation pointing to that, but I thought that was the policy. In
> particular, we require VS 2015 or above, which doesn't support anything older
> than Server 2008 anyway (including Vista and XP), and I doubt we'd have
> anyone using Server 2008.
For llvm itself, yes, but this is for the runtimes. Or does the policy cover
that as well?
Mingw upstream still(!) default to supporting xp onwards, while I'm configuring
my own setups to default to vista. I guess making that 7 wouldn't be too much
of an issue though.
FWIW, I included a corresponding change for ASAN here:
https://reviews.llvm.org/rCRT343074, in adding a `append_list_if(MINGW psapi
ASAN_DYNAMIC_LIBS)` in compiler-rt/trunk/lib/asan/CMakeLists.txt.
Repository:
rC Clang
https://reviews.llvm.org/D52990
_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
