tamur added inline comments.
================ Comment at: lib/Basic/Targets/X86.cpp:865 + if (CodeModel == "default") + // When the user has not explicitly specified anything, + // the default code model to use is small. ---------------- MaskRay wrote: > I'm not sure if the comment is useful here... or you can comment that this > piece of code should be consistent with X86TargetMachine.cpp#L208 I removed the comment, Done. What I had wanted was to explain why we have a __code_model_small_ macro, not e.g. __code_model_default_ macro, but maybe it will be obvious to future readers. Repository: rC Clang https://reviews.llvm.org/D52920 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
