scott.linder added a comment. I will update the patch to modify the HIP toolchain and to add tests for global variables.
As far as the semantics are concerned, are we OK with this being AMDGPU only? I do not see a means of determining what is a "kernel" in a language-agnostic way other than checking for our AMDGPU-specific calling convention. If there is a more general mechanism, this could be implemented in `LinkageComputer::getLVForNamespaceScopeDecl` instead. As it stands, it sounds like being AMDGPU specific, but omitting `amdgpu` from the option name is preferred? What about: -fvisibility-non-offload-functions=<arg> Set the default symbol visibility for non-offload function declarations (AMDGPU only) I cannot think of a way to avoid `non` or something similar ending up in the name. https://reviews.llvm.org/D52891 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
