rjmccall accepted this revision.
rjmccall added a comment.

LGTM.



================
Comment at: lib/CodeGen/CGCall.cpp:2049
+        // from the constructor’s this pointer, the value of the object or
+        // subobject thus obtained is unspecified.
+        unsigned ThisIRArg, NumIRArgs;
----------------
rjmccall wrote:
> You probably ought to add here that we're treating this as undefined behavior 
> and have recommended the standard be changed.
Thanks, looks good.


https://reviews.llvm.org/D46441



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
  • [PATCH] D46441: [... John McCall via Phabricator via cfe-commits
    • [PATCH] D464... John McCall via Phabricator via cfe-commits
    • [PATCH] D464... Anton Bikineev via Phabricator via cfe-commits
    • [PATCH] D464... Richard Smith - zygoloid via Phabricator via cfe-commits
    • [PATCH] D464... Anton Bikineev via Phabricator via cfe-commits

Reply via email to