hokein added inline comments.

================
Comment at: clangd/index/FileIndex.h:78
+  /// Remove all index data associated with the file \p Path.
+  void removeFile(PathRef Path);
+
----------------
ioeric wrote:
> should we use this somewhere? E.g. when file is closed in ClangdServer?
Yes, the usage of this method is not included in this patch. 

We probably use this function in `TUScheduler::remove`, the code path will be 
like

`TUScheduler::remove => ParsingCallback::onASTRemove => FileIndex::removeFile`.

We need to add a similar interface to `ParsingCallback`.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D52979



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to