hokein accepted this revision. hokein added a comment. This revision is now accepted and ready to land.
The change looks reasonable to me, so lg. I'd wait a bit to see whether other reviewers have comments. ================ Comment at: lib/Index/USRGeneration.cpp:339 +void USRGenerator::VisitBindingDecl(const BindingDecl *D) { + if (D->getParentFunctionOrMethod() && GenLoc(D, /*IncludeOffset=*/true)) + return; ---------------- use `isLocal(D)` instead. Repository: rC Clang https://reviews.llvm.org/D52445 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits