Author: jonastoth Date: Thu Oct 4 08:59:30 2018 New Revision: 343792 URL: http://llvm.org/viewvc/llvm-project?rev=343792&view=rev Log: [clang-tidy] NFC use CHECK-NOTES in tests for fuchsia-default-arguments
Reviewers: alexfh, aaron.ballman, hokein Reviewed By: alexfh Subscribers: xazax.hun, cfe-commits Differential Revision: https://reviews.llvm.org/D52688 Modified: clang-tools-extra/trunk/test/clang-tidy/fuchsia-default-arguments.cpp Modified: clang-tools-extra/trunk/test/clang-tidy/fuchsia-default-arguments.cpp URL: http://llvm.org/viewvc/llvm-project/clang-tools-extra/trunk/test/clang-tidy/fuchsia-default-arguments.cpp?rev=343792&r1=343791&r2=343792&view=diff ============================================================================== --- clang-tools-extra/trunk/test/clang-tidy/fuchsia-default-arguments.cpp (original) +++ clang-tools-extra/trunk/test/clang-tidy/fuchsia-default-arguments.cpp Thu Oct 4 08:59:30 2018 @@ -1,14 +1,13 @@ // RUN: %check_clang_tidy %s fuchsia-default-arguments %t int foo(int value = 5) { return value; } -// CHECK-MESSAGES: [[@LINE-1]]:9: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments] +// CHECK-NOTES: [[@LINE-1]]:9: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments] // CHECK-FIXES: int foo(int value) { return value; } int f() { foo(); - // CHECK-MESSAGES: [[@LINE-1]]:3: warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments] - // CHECK-NEXT: note: default parameter was declared here: - // CHECK-NEXT: int foo(int value = 5) { return value; } + // CHECK-NOTES: [[@LINE-1]]:3: warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments] + // CHECK-NOTES: [[@LINE-8]]:9: note: default parameter was declared here } int bar(int value) { return value; } @@ -21,7 +20,7 @@ int n() { class Baz { public: int a(int value = 5) { return value; } - // CHECK-MESSAGES: [[@LINE-1]]:9: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments] + // CHECK-NOTES: [[@LINE-1]]:9: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments] // CHECK-FIXES: int a(int value) { return value; } int b(int value) { return value; } @@ -30,7 +29,7 @@ public: class Foo { // Fix should be suggested in declaration int a(int value = 53); - // CHECK-MESSAGES: [[@LINE-1]]:9: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments] + // CHECK-NOTES: [[@LINE-1]]:9: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments] // CHECK-FIXES: int a(int value); }; @@ -41,7 +40,7 @@ int Foo::a(int value) { // Elided functions void f(int = 5) {}; -// CHECK-MESSAGES: [[@LINE-1]]:8: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments] +// CHECK-NOTES: [[@LINE-1]]:8: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments] // CHECK-FIXES: void f(int) {}; void g(int) {}; @@ -50,12 +49,12 @@ void g(int) {}; #define D(val) = val void h(int i D(5)); -// CHECK-MESSAGES: [[@LINE-1]]:8: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments] +// CHECK-NOTES: [[@LINE-1]]:8: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments] // CHECK-FIXES-NOT: void h(int i); void x(int i); void x(int i = 12); -// CHECK-MESSAGES: [[@LINE-1]]:8: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments] +// CHECK-NOTES: [[@LINE-1]]:8: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments] // CHECK-FIXES: void x(int i); void x(int i) {} @@ -65,17 +64,17 @@ struct S { }; void S::x(int i = 12) {} -// CHECK-MESSAGES: [[@LINE-1]]:11: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments] +// CHECK-NOTES: [[@LINE-1]]:11: warning: declaring a parameter with a default argument is disallowed [fuchsia-default-arguments] // CHECK-FIXES: void S::x(int i) {} int main() { S s; s.x(); - // CHECK-MESSAGES: [[@LINE-1]]:3: warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments] - // CHECK-NEXT: note: default parameter was declared here: + // CHECK-NOTES: [[@LINE-1]]:3: warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments] + // CHECK-NOTES: [[@LINE-9]]:11: note: default parameter was declared here // CHECK-NEXT: void S::x(int i = 12) {} x(); - // CHECK-MESSAGES: [[@LINE-1]]:3: warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments] - // CHECK-NEXT: note: default parameter was declared here: + // CHECK-NOTES: [[@LINE-1]]:3: warning: calling a function that uses a default argument is disallowed [fuchsia-default-arguments] + // CHECK-NOTES: [[@LINE-19]]:8: note: default parameter was declared here // CHECK-NEXT: void x(int i = 12); } _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits
