ldionne marked an inline comment as done.
ldionne added inline comments.

================
Comment at: clang/lib/Sema/Sema.cpp:648
+          !FD->getMostRecentDecl()->isInlined() &&
+          !FD->hasAttr<ExcludeFromExplicitInstantiationAttr>())
         continue;
----------------
rsmith wrote:
> What's the purpose of this change?
It's so that we diagnose a member function marked with 
`exclude_from_explicit_instantiation` that is used but not defined just like we 
do for an `inline` function. This causes us to `push_back` the declaration 
(line 668 below) into the vector of `Undefined`-but-used declarations, which we 
use to trigger a diagnostic somewhere else.


Repository:
  rC Clang

https://reviews.llvm.org/D51789



_______________________________________________
cfe-commits mailing list
cfe-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits

Reply via email to