lebedev.ri added inline comments.
================ Comment at: clang-tidy/utils/Matchers.cpp:18-19 + +Matcher<NamedDecl> +matchesAnyListedName(const std::vector<std::string> &NameList) { + SmallString<256> NameRegEx; ---------------- baloghadamsoftware wrote: > lebedev.ri wrote: > > Actually wait, what is this? > > It should be something like > > ``` > > AST_MATCHER_P(NamedDecl, matchesAnyListedName, std::vector<std::string> &, > > NameList) { > > ... > > ``` > Taken from `cppcoreguidelines-no-malloc` as @JonasToth suggested. Ok, but as you can see in `clang-tidy/utils/Matchers.h` (and `ASTMatchers.h`), it's not really correct prototype. https://reviews.llvm.org/D52727 _______________________________________________ cfe-commits mailing list cfe-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits